Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Cloud Security] add the cloud formation credentials url #9828

Merged
merged 3 commits into from
May 14, 2024
Merged

[Cloud Security] add the cloud formation credentials url #9828

merged 3 commits into from
May 14, 2024

Conversation

Omolola-Akinleye
Copy link
Contributor

@Omolola-Akinleye Omolola-Akinleye commented May 9, 2024 •
edited
Loading

Proposed commit message

Add cloud formation credentials template url which help users create stack to automate direct access keys to copy and paste to input fields

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Related issues

Screenshots

image

@Omolola-Akinleye Omolola-Akinleye self-assigned this May 9, 2024
@Omolola-Akinleye Omolola-Akinleye requested a review from a team as a code owner May 9, 2024 21:55
@elasticmachine
Copy link

🚀 Benchmarks report

To see the full report comment with /test benchmark fullreport

seanrathier
seanrathier approved these changes May 10, 2024
View reviewed changes
Copy link
Contributor

@seanrathier seanrathier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved with a couple of comments

packages/cloud_security_posture/manifest.yml Outdated
multi: false
required: true
show_user: false
description: Template URL to create cloud credentials to Create Stack
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be "Template URL to create cloud credentials for Create Stack"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will change it to Template URL to Cloud Formation Cloud Credentials Stack similar description structure to Template URL to Cloud Formation Quick Create Stack

packages/cloud_security_posture/manifest.yml Outdated
show_user: false
description: Template URL to create cloud credentials to Create Stack
# ACCOUNT_TYPE value should be either "single-account" or "organization-account"
default: https://console.aws.amazon.com/cloudformation/home#/stacks/quickcreate?templateURL=https://elastic-cspm-cft.s3.eu-central-1.amazonaws.com/cloudformation-cspm-direct-access-key-ACCOUNT-TYPE-8.14.0.yml
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be version 8.15.0.yml?

Copy link
Contributor Author

@Omolola-Akinleye Omolola-Akinleye May 13, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes @seanrathier once this PR I will change version to 8.15.0

@kfirpeled kfirpeled linked an issue May 12, 2024 that may be closed by this pull request
[Cloud Security] Automated creation of cloud credentials elastic/kibana#175977
Closed
2 tasks
@orouz
Copy link
Contributor

orouz commented May 13, 2024

@Omolola-Akinleye

i talked to @maxcold about this a while ago and i think if it's possible to just store these values in kibana that'd be preferable

@Omolola-Akinleye
Copy link
Contributor Author

Omolola-Akinleye commented May 13, 2024 •
edited
Loading

@Omolola-Akinleye

i talked to @maxcold about this a while ago and i think if it's possible to just store these values in kibana that'd be preferable

Hey @orouz I missing some context. Would you remind me why we want to store these values in Kibana? I discussed with @kfirpeled and we decided to use Integration so when the package version is being upgraded along with the template url version will be upgraded.

Also, @orouz @oren-zohar Does the Go version change align with Kibana upgrades or downgrades? Before the merge, I encountered Access Denied error when my kibana version is 8.15.0 and the hardcoded template url (https://elastic-cspm-cft.s3.eu-central-1.amazonaws.com/cloudformation-cspm-direct-access-key-ACCOUNT-TYPE-8.15.0.yml` ). This could be a potential issue with maintain version on Kibana side.

@elasticmachine
Copy link

💚 Build Succeeded

History

cc @Omolola-Akinleye

@elastic-sonarqube Elastic SonarQube
Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

@oren-zohar
Copy link
Contributor

@Omolola-Akinleye I think @orouz raise an interesting point and we should discuss it offline, but it's out of this PR scope, so feel free to merge if you think it's ready

@Omolola-Akinleye
Copy link
Contributor Author

@Omolola-Akinleye I think @orouz raise an interesting point and we should discuss it offline, but it's out of this PR scope, so feel free to merge if you think it's ready

Thanks @oren-zohar @orouz I'll merge for now, and create a thread to discuss offline

@Omolola-Akinleye Omolola-Akinleye merged commit 436116d into elastic:main May 14, 2024
5 checks passed
@elasticmachine
Copy link

Package cloud_security_posture - 1.10.0-preview01 containing this change is available at https://epr.elastic.co/search?package=cloud_security_posture

@elasticmachine
Copy link

Package cloud_asset_inventory - 0.1.0 containing this change is available at https://epr.elastic.co/search?package=cloud_asset_inventory

@elasticmachine
Copy link

Package cloud_asset_inventory - 0.1.1 containing this change is available at https://epr.elastic.co/search?package=cloud_asset_inventory

bmorelli25 pushed a commit to bmorelli25/integrations that referenced this pull request Jun 3, 2024
@Omolola-Akinleye @bmorelli25
[Cloud Security] add the cloud formation credentials url (elastic#9828)
a3a5947 
* add the cloud formation credentials url

* add cloud credentials change for changelog

* use 8.15.0 version and change description
@elasticmachine
Copy link

Package cloud_asset_inventory - 0.1.2 containing this change is available at https://epr.elastic.co/search?package=cloud_asset_inventory

@elasticmachine
Copy link

Package cloud_asset_inventory - 0.1.4 containing this change is available at https://epr.elastic.co/search?package=cloud_asset_inventory

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seanrathier seanrathier seanrathier approved these changes

@orestisfl orestisfl orestisfl approved these changes

Assignees

@Omolola-Akinleye Omolola-Akinleye

Labels
8.15 candidate enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Cloud Security] Automated creation of cloud credentials
6 participants
@Omolola-Akinleye @elasticmachine @orouz @oren-zohar @seanrathier @orestisfl